NE-2090: adding one GIE automation test #30189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@rhamini3: This pull request references NE-2090 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
/test all |
| o.Expect(errCheck).NotTo(o.HaveOccurred(), "GatewayClass %q was not installed and accepted", gatewayClassName) | ||
|
|
||
| g.By("Install the GIE CRD") | ||
| err := oc.AsAdmin().Run("create").Args("-f", infPoolCRD).Execute() |
There was a problem hiding this comment.
Don't we need a defer like function for removing the GIE CRD ?
may be in the g.AfterAll(func().
There was a problem hiding this comment.
@melvinjoseph86 removing the inference Pool CRD is a part of the test process, I do it below to confirm that the istio no longer has the env variable
yes, no problem |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: c32e8d3
New tests seen in this PR at sha: c32e8d3
|
|
Job Failure Risk Analysis for sha: a82a19a
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: a82a19a
|
|
/assign @Thealisyed |
alebedev87
reviewed
Sep 15, 2025
|
/lgtm |
|
/verified |
|
@rhamini3: The In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified by rhamini3 |
openshift-ci-robot
added
the
verified
|
@rhamini3: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Thealisyed
reviewed
Sep 16, 2025
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87, rhamini3, sosiouxme, Thealisyed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
@rhamini3: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: 76d4673
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 76d4673
New tests seen in this PR at sha: 76d4673
|
openshift-merge-bot
bot
merged commit e6d0b63
into
openshift:main
28 of 47 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NE QE team decided to create one GIE test to check for GIE enablement with the presence of an env variable
CC @lihongan @melvinjoseph86 @ShudiLi PTAL
test result: